Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs for native sign in using Apple SDK #1528

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

ory/kratos#3476

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas
Copy link
Member Author

Pls don't merge yet, not on Ory Network yet.

Google is not implemented yet, will do next!

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also link the documentation to here from https://docs-cazi73gk0-ory.vercel.app/docs/kratos/social-signin/native-apps? Since it is now possible to have complete native flows instead of browser in native apps.

docs/kratos/social-signin/30_apple.mdx Outdated Show resolved Hide resolved
docs/kratos/social-signin/30_apple.mdx Outdated Show resolved Hide resolved
docs/kratos/social-signin/30_apple.mdx Show resolved Hide resolved
@jonas-jonas jonas-jonas merged commit 6bd8cfe into master Sep 14, 2023
10 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/addNativeSignInAppleDocs branch September 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants